Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorrect top-scope variable warning for define #205

Merged
merged 2 commits into from
Aug 24, 2013
Merged

incorrect top-scope variable warning for define #205

merged 2 commits into from
Aug 24, 2013

Conversation

rodjek
Copy link
Owner

@rodjek rodjek commented Aug 24, 2013

puppet-lint gives the error "top-scope variable being used without an explicit namespace" for the first three parameters; no warning is given if they have default values provided.

define tomcat::base (
    $initial_heap,
    $max_heap,
    $max_perm_gen,
    $owner = hiera('app_user'),
    $classpath = [],
    $enable_manager = false,
    $system_properties = {},
) { … }

@rodjek
Copy link
Owner

rodjek commented Jun 19, 2013

Which version of puppet-lint are you using?

@blalor
Copy link
Author

blalor commented Jun 20, 2013

0.3.2

rodjek pushed a commit that referenced this pull request Aug 24, 2013
incorrect top-scope variable warning for define
@rodjek rodjek merged commit 72a384d into master Aug 24, 2013
@rodjek rodjek deleted the issue-205 branch August 24, 2013 20:09
ekohl pushed a commit to ekohl/puppet-lint that referenced this pull request Jul 5, 2024
Revert "(maint) Update labeller.yml to pull_request"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants