Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Puppet-lint fails to handle mac line endings #183

Merged
merged 3 commits into from
Sep 14, 2013
Merged

Puppet-lint fails to handle mac line endings #183

merged 3 commits into from
Sep 14, 2013

Conversation

rodjek
Copy link
Owner

@rodjek rodjek commented Sep 14, 2013

Puppet-lint fails on files using a single CR as a line ending, while puppet parser validate works fine with them:

hexdump -C:

    00000000  63 6c 61 73 73 20 67 61  6d 65 73 65 72 76 65 72  |class gameserver|
    00000010  73 20 7b 0d 7d                                    |s {.}|

This file was

    class gameservers{^M}

Errors reported:

    $ puppet-lint ./modules/gameservers/manifests/init.pp
    ERROR: Syntax error (try running `puppet parser validate <file>`) on line 1
    $ puppet parser validate ./modules/gameservers/manifests/init.pp
    $ echo $?
    0

@rodjek
Copy link
Owner

rodjek commented Aug 3, 2013

You're running Puppet on a pre-OSX mac? Impressive ;)

@devicenull
Copy link
Author

Nope, just a terrible combination of various developers and various apps mangling line endings along the way.

rodjek pushed a commit that referenced this pull request Sep 14, 2013
Puppet-lint fails to handle mac line endings
@rodjek rodjek merged commit 0dcd36c into master Sep 14, 2013
@rodjek rodjek deleted the issue-183 branch September 14, 2013 00:25
@rodjek
Copy link
Owner

rodjek commented Sep 14, 2013

This should handle this situation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants