Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration's ignore_paths is not respected #774

Closed
jarro2783 opened this issue Oct 27, 2017 · 5 comments
Closed

Configuration's ignore_paths is not respected #774

jarro2783 opened this issue Oct 27, 2017 · 5 comments
Labels
Milestone

Comments

@jarro2783
Copy link

In puppet-lint-2.3.3, setting PuppetLint.configuration.ignore_paths is ignored.

Our rake task does this:

PuppetLint.configuration.ignore_paths = [
  'ext_modules/**/*',
  'spec/fixtures/**/*',
  'vendor/**/*',
]
PuppetLint::RakeTask.new(:puppet_lint)

and all of those paths are linted.

I think it was broken by #762, which fixed setting ignore_paths in the task body, but broke reading it from outside.

The reason is that the default is

@ignore_paths = []

which when evaluated here:

@ignore_paths ||= PuppetLint.configuration.ignore_paths

is truthy and therefore is never set to PuppetLint.configuration.ignore_paths.

alzabo pushed a commit to alzabo/puppet-lint that referenced this issue Nov 1, 2017
The value of `PuppetLint.configuration.ignore_paths` was ignored,
as described in issue rodjek#774
alzabo added a commit to alzabo/puppet-lint that referenced this issue Nov 1, 2017
The value of `PuppetLint.configuration.ignore_paths` was ignored,
as described in issue rodjek#774
@rodjek
Copy link
Owner

rodjek commented Nov 2, 2017

Resolved by #777

@rodjek rodjek closed this as completed Nov 2, 2017
@rodjek rodjek added this to the 2.3.4 milestone Nov 2, 2017
@rodjek rodjek added the bug label Nov 2, 2017
@joshuaspence
Copy link

Any plans to release a new version soon now that this issue has been resolved?

@rodjek
Copy link
Owner

rodjek commented Nov 28, 2017

@joshuaspence Yep, this will be part of the 2.3.4 later this week.

@joshuaspence
Copy link

Bump. It seems that 2.3.4 still has not yet been released.

@alex-harvey-z3q
Copy link

It's 4 months now. A workaround:

# Version 2.3.3 introduced a bug in ignore_paths.                              
#                                                                              
gem 'puppet-lint', '< 2.3.3', :require => false

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants