ssh_key can't be broken up by \

[rkhatibi]

At least I haven't figured out how to yet. What I've found works is adding an exception into whitespace.rb.

  # SHOULD NOT exceed an 80 character line width
  unless line =~ /puppet:\/\// || line =~ /AAAAB3NzaC1/

AAAAB3NzaC1 should match either an RSA or DSA key.

[rodjek]

Honestly, I think for readability you should be putting the content of your SSH keys into templates. There's a significant difference between a puppet:// uri that is 90 chars and a 500+ char SSH key.

[rkhatibi]

I think you're right in that we can't handle all bits of data in puppet-lint. However I'm not sure putting everything in a template or redirecting through variables makes any more sense... though I suppose if we're aiming for separating data from code it does make more sense. Perhaps I'll patch my local copy to run the length check on files in ./lib/ which is code and skip manifests for now.

[rodjek]

The whole point of puppet-lint as I see it is to provide you with hints to keep your manifests clean, consistent and above all, readable. Enforcing the separation of code and data is a big part of that IMHO.

I'm open to adjusting the checks as we've done for puppet:// URIs (splitting these into multiple lines would hurt readability rather than enhance it) but in this case, I really feel that moving the contents of the key out of the manifest is the way to go.

Counter arguments are welcome though :)

Also, there's no need to patch puppet-lint locally, you can disable the 80char check with the --no-80chars-check flag.

[rkhatibi]

I spent some time this weekend cleaning up my manifests and have come around to your point of view. Thanks for taking the time to talk me through it. Marking this closed.