Avoid internal error for typoed namespace

Fixes #853
rodjek · Feb 23, 2019 · 0fbe52e · 0fbe52e
1 parent 3c379cf
commit 0fbe52e
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/lib/puppet-lint/data.rb b/lib/puppet-lint/data.rb
@@ -201,6 +201,9 @@ def find_resource_type_token(index)
       lbrace_idx = tokens[0..index].rindex do |token|
         token.type == :LBRACE && token.prev_code_token.type != :QMARK
       end
+
+      raise PuppetLint::SyntaxError, tokens[index] if lbrace_idx.nil?
+
       tokens[lbrace_idx].prev_code_token
     end
 

diff --git a/spec/puppet-lint/data_spec.rb b/spec/puppet-lint/data_spec.rb
@@ -20,6 +20,18 @@
         }
       end
     end
+
+    context 'when typo in namespace separator makes parser look for resource' do
+      let(:manifest) { '$testparam = $::module:;testparam' }
+
+      it 'raises a SyntaxError' do
+        expect {
+          data.resource_indexes
+        }.to raise_error(PuppetLint::SyntaxError) { |error|
+          expect(error.token).to eq(data.tokens[5])
+        }
+      end
+    end
   end
 
   describe '.insert' do