Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add user module unit test #1787

Merged
merged 4 commits into from
Nov 25, 2024
Merged

Conversation

arsforza
Copy link
Contributor

@arsforza arsforza commented Nov 18, 2024

closes #1603

Describe your changes

Brief description of your changes - not in-depth because the bulk of the description should be in the task on DevOps.

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added tests wherever relevant
  • I have made sure that all automated checks pass before requesting a review

Notes for the reviewer

@gulfaraz: @jannisvisser and I decided to add a test on generateJWT because:

  • other functionalities are already covered by API tests
  • the remaining non-tested methods in the service are just database calls and we felt they didn't need a unit test

@arsforza arsforza force-pushed the test.user-module-unit-test branch from 4d5149f to 0816763 Compare November 18, 2024 14:03
@arsforza arsforza requested a review from gulfaraz November 18, 2024 14:47
Copy link
Contributor

@jannisvisser jannisvisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arsforza looks good. I can confirm that this is what we agreed on together. But good for @gulfaraz to also review, and to thereby also look at the user module integration tests.

Copy link
Member

@gulfaraz gulfaraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @arsforza

@jannisvisser
Copy link
Contributor

Merging this in andrea's absence @gulfaraz

@jannisvisser jannisvisser merged commit c06db3c into master Nov 25, 2024
8 checks passed
@jannisvisser jannisvisser deleted the test.user-module-unit-test branch November 25, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add 1 unit test for user module
3 participants