Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add map service unit tests #1730

Merged
merged 11 commits into from
Nov 11, 2024
Merged

test: add map service unit tests #1730

merged 11 commits into from
Nov 11, 2024

Conversation

arsforza
Copy link
Contributor

@arsforza arsforza commented Oct 29, 2024

closes #1608

Describe your changes

Brief description of your changes - not in-depth because the bulk of the description should be in the task on DevOps.

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added tests wherever relevant
  • I have made sure that all automated checks pass before requesting a review

Notes for the reviewer

  1. Any helpful instructions or clarifications...

@arsforza arsforza added the test This involves testing label Oct 29, 2024
@arsforza arsforza force-pushed the test.map-unit-tests branch from d12cab8 to f8e038a Compare October 29, 2024 14:01
@arsforza arsforza requested a review from jannisvisser November 5, 2024 08:12
Copy link
Contributor

@jannisvisser jannisvisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good Andrea. Maybe read through the comments and then shortly call about it?

@arsforza arsforza force-pushed the test.map-unit-tests branch from cb4334d to 0b9db1b Compare November 11, 2024 13:02
Copy link
Contributor

@jannisvisser jannisvisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small changes, for the rest looks good now I think!

@arsforza arsforza merged commit 4f028e0 into master Nov 11, 2024
8 checks passed
@arsforza arsforza deleted the test.map-unit-tests branch November 11, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test This involves testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add 3 unit tests for map service
2 participants