Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use composite action, remove build steps for api and dashboard #1598

Merged
merged 26 commits into from
Oct 1, 2024

Conversation

gulfaraz
Copy link
Member

@gulfaraz gulfaraz commented Sep 30, 2024

Describe your changes

  1. Changed e2e workflow to run as a part of the CI workflow.
  2. Added integration tests to the CI workflow.
  3. Changed the default port to 3000 to make the current tests work.

The next ones were needed to pass the integration tests,

  1. Added a check to confirm if the directory exists before reading it.
  2. Unlinked the integration tests from the seed data.
  3. Added MWI, SSD, and flash-flood to example.env.

The next ones were needed to clean up warnings,

  1. Upload the e2e dashboard log as a Github action artefact.
  2. Added assertions to the integration tests.

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added tests wherever relevant
  • I have made sure that all automated checks pass before requesting a review

Notes for the reviewer

  1. I tried to update the tests to run without the API-service installation but it took too much effort so created the follow-up issue instead.
  2. You can see the new workflow in action here.

@jannisvisser jannisvisser merged commit 8145e1a into master Oct 1, 2024
8 checks passed
@jannisvisser jannisvisser deleted the ci.e2e branch October 1, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants