fix: update indicator info popup copy

[gulfaraz]

Describe your changes

This PR includes,

1. Changes to indicator copy according to Figma for https://github.com/rodekruis/Anticipatory-Action/issues/644
2. Update html links to avoid this security issue

Checklist before requesting a review

• I have performed a self-review of my code
• I have added tests wherever relevant
• I have made sure that all automated checks pass before requesting a review

Notes for the reviewer

1. Copy changes can be reviewed in isolation using this commit.

[gulfaraz]

> test:api:all
> node --expose-gc node_modules/.bin/jest --config=jest.api.config.js --runInBand --detectOpenHandles --logHeapUsage

ts-jest[versions] (WARN) Version 4.9.5 of typescript installed has not been tested with ts-jest. If you're experiencing issues, consider using a supported version (>=2.7.0 <4.0.0). Please do not report issues in ts-jest if you are using unsupported versions.
 PASS  test/email/floods/email-uga-floods.test.ts (31.047s, 81 MB heap size)
  Should send an email for uga floods
    ✓ default (6367ms)
    ✓ warning (7520ms)
    ✓ warning-to-trigger (8586ms)
    ✓ no-trigger (7989ms)

 PASS  test/email/flash-flood/email-mwi-flash-flood.test.ts (31.292s, 80 MB heap size)
  Should send an email for mwi flash flood
    ✓ default (8482ms)
    ✓ no-trigger (22716ms)

 PASS  test/email/malaria/email-eth-malaria.test.ts (19.165s, 81 MB heap size)
  Should send an email for eth malaria
    ✓ default (8775ms)
    ✓ no-trigger (10303ms)

 PASS  test/email/floods/email-ssd-floods.test.ts (14.999s, 81 MB heap size)
  Should send an email for ssd floods
    ✓ default (8478ms)
    ✓ no-trigger (6420ms)

 PASS  test/email/dengue/email-phl-dengue.test.ts (16.758s, 81 MB heap size)
  Should send an email for phl dengue
    ✓ default (8256ms)
    ✓ no-trigger (8421ms)

 PASS  test/email/drought/email-uga-drought.test.ts (15.685s, 90 MB heap size)
  Should send an email for uga drought
    ✓ triggered in january (8455ms)
    ✓ non triggered any month (7137ms)

 PASS  test/email/typhoon/email-phl-typhoon.test.ts (10.613s, 88 MB heap size)
  Should send an email for phl typhoon
    ✓ default (10527ms)

Test Suites: 7 passed, 7 total
Tests:       15 passed, 15 total
Snapshots:   0 total
Time:        139.964s, estimated 141s
Ran all test suites.

[jannisvisser]

@gulfaraz

1. This PR is missing a link to which Github issue it belongs I think. UPDATE, sorry just saw it.
2. From this commit it seems you are unaware of the process that is in place to update info popup copy (see readme here https://github.com/rodekruis/IBF-system/tree/master/services/API-service/src/scripts/json). I am not 100% sure that readme is fully up to date, and I am 100% sure that this process is not the greatest either, but at least that process should largely still be in place.
3. Fine to remove target='_blank' if it's a security risk, but should we at least think about an alternative, because it's really annoying for users if a link opens in the same tab and thereby they lose their view of the IBF portal?

[gulfaraz]

From this commit it seems you are unaware of the process that is in place to update info popup copy (see readme here https://github.com/rodekruis/IBF-system/tree/master/services/API-service/src/scripts/json). I am not 100% sure that readme is fully up to date, and I am 100% sure that this process is not the greatest either, but at least that process should largely still be in place.

I will read this process. It seemed straightforward to make the change directly so I didn't search for a process. Is there anything I missed because I made this change manually?

Fine to remove target='_blank' if it's a security risk, but should we at least think about an alternative, because it's really annoying for users if a link opens in the same tab and thereby they lose their view of the IBF portal?

Most users find it annoying that a link opens in a new tab. The better UX is to open in the same tab, as cited in StackOverflow and UX Stack Exchange. In my workflow, I do a Ctrl+Click if I want a link to open in a new tab.

I removed the target='_blank' in this PR as it is a security fix. Let's discuss the alternative and how links should behave in IBF in a new issue. Is there anything else that blocks this merge?

[jannisvisser]

@gulfaraz thanks for you answers:

• I don't think you missed anything, but the process is there so that data/design people can also update UX copy (by doing so in the xlsx). The process ensures that xlsx and json stay aligned, because otherwise we lose/overwrite changes in the future. Please feel free off course to offer/implement suggestions.
• clear on the target=blank, all good then.