more lxqt-files #613
Merged
more lxqt-files #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
first file for the LXQT 2.0 desktop group
starter file for LXQT Desktop
I use sddm as display manager I cant remove the other file - only use graphical env., sorry After startlxqt i would add 2 lines to sddm to enable the start of LXQT desktop
Enable sddm to start an lxqt desktop session
lxqt-session to be started by startlxqt. Display manager: sddm
is needed for several complaints:
DENIED kscreen_backend_launcher open owner @{user_config_dirs}/lxqt/lxqt.conf comm=kscreen_backend requested_mask=r denied_mask=r
DENIED kscreen_backend_launcher open /usr/share/lxqt/lxqt.conf comm=kscreen_backend requested_mask=r denied_mask=r
DENIED kscreen_backend_launcher open owner @{user_config_dirs}/lxqt/session.conf comm=kscreen_backend requested_mask=r denied_mask=r
DENIED kscreen_backend_launcher open /usr/share/lxqt/session.conf comm=kscreen_backend requested_mask=r denied_mask=r
add child-open
you think its too permissive to have app-launcher-user here, right?
add needed programs
turning back to layout of corresponding xfce file.
startlxqtwayland for starting the session, support for labwc and kwin_wayland
nobody43
reviewed
Nov 23, 2024
| @{sys}/devices/@{pci_bus}/0000:00:02.0/drm/card@{int}/card@{int}-eDP-@{int}/intel_backlight/ r, | ||
| @{sys}/devices/@{pci_bus}/0000:00:02.0/drm/card@{int}/card@{int}-eDP-@{int}/intel_backlight/max_brightness r, | ||
| @{sys}/devices/@{pci_bus}/0000:00:02.0/drm/card@{int}/card@{int}-eDP-@{int}/intel_backlight/bl_power r, | ||
| @{sys}/devices/@{pci_bus}/0000:00:02.0/drm/card@{int}/card@{int}-eDP-@{int}/intel_backlight/actual_brightness r, |
There was a problem hiding this comment.
Hello, could you please comment abit more than just a word. thank you
There was a problem hiding this comment.
Should start with @{sys}/devices/@{pci}/, check other examples:
grep -r \{pci\} apparmor.d/
There was a problem hiding this comment.
ah, ok changed that
roddhjav
reviewed
Nov 29, 2024
Comment on lines
29
to
34
| @{sys}/devices/@{pci}/**/drm/card@{int}/card@{int}-eDP-@{int}/intel_backlight/* rw, | ||
| @{sys}/devices/@{pci}/0000:00:02.0/drm/card@{int}/card@{int}-eDP-@{int}/intel_backlight/ r, | ||
| @{sys}/devices/@{pci}/0000:00:02.0/drm/card@{int}/card@{int}-eDP-@{int}/intel_backlight/max_brightness r, | ||
| @{sys}/devices/@{pci}/0000:00:02.0/drm/card@{int}/card@{int}-eDP-@{int}/intel_backlight/bl_power r, | ||
| @{sys}/devices/@{pci}/0000:00:02.0/drm/card@{int}/card@{int}-eDP-@{int}/intel_backlight/actual_brightness r, | ||
| @{sys}/devices/@{pci}/**/**/drm/card@{int}/card@{int}-eDP-1/amdgpu_bl@{int}/* r, |
There was a problem hiding this comment.
That cannot be let like this:
- This is intel/amd specific
- This is specific to a display port output.
0000:00:02.0is part of the pci address. This address often refers to the first GPU connected.
Have a look at the profile xfpm-power-backlight-helper and copy all sys rules from it. This is what you need here.
ok, havent seen this profile yet. I will change that in lxqt-powermanagement as well and check the other profiles
|
hmm, dont know what the problem is with the last check |
|
Don't worry, it does not concern your PR. The CI failed because an up to date version of Ubuntu now requires more rules related to snap. In other words, the CI did its jobs... and it is good. |
|
Thanks, merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add initial support for new wayland session in lxqt 2.1 using labwc and kwin_wayland.