Create vesktop #512
Merged
Create vesktop #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roddhjav
reviewed
Sep 23, 2024
Comment on lines
+40
to
+41
| deny /dev/tty rw, | ||
| deny owner /dev/tty@{int} rw, |
There was a problem hiding this comment.
As a silencer. It asks for these permissions but I don't think that it actually needs them, as everything on the program works fine, and AFAIK (correct me if I'm wrong) access to /dev/tty allows the program to escape confinement so I thought it was better to deny.
There was a problem hiding this comment.
Do you have any source of this?
There was a problem hiding this comment.
For the possible /dev/tty escapes? https://www.errno.fr/TTYPushback.html and containers/bubblewrap#142
There was a problem hiding this comment.
Thanks. This has been discussed here: #340
Spoiler alert: the solution is not apparmor.
|
Thanks, merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.