Create profile for sing-box #273
Conversation
|
Thanks for your PR. Please have a look at the profile guideline: https://apparmor.pujol.io/development/guidelines to ensure your profile respect the guideline of this project. Looking at the documentation of sing-box. I have the feeling, this profile only works for your use case of the proxy (with tor), what about other feature? |
apparmor.d/profiles-s-z/sing-box
Outdated
| @{exec_path} = /{,usr/}{,local/}bin/sing-box | ||
| profile sing-box @{exec_path} { | ||
| include <abstractions/base> | ||
| include <abstractions/nameservice> |
apparmor.d/profiles-s-z/sing-box
Outdated
|
|
||
| include <tunables/global> | ||
|
|
||
| @{exec_path} = /{,usr/}{,local/}bin/sing-box |
There was a problem hiding this comment.
Use @{bin}/sing-box (local program are purposely not confined by default profiles)
apparmor.d/profiles-s-z/sing-box
Outdated
| include <abstractions/nis> | ||
| include <abstractions/ssl_certs> | ||
| include <abstractions/ssl_keys> | ||
| include <abstractions/tor> |
apparmor.d/profiles-s-z/sing-box
Outdated
| /usr/{,local/}share/sing-box/geosite.db r, | ||
|
|
||
| owner /{,usr/local/}etc/sing-box/config.json r, | ||
| owner @{home_dirs}/.local/share/certmagic/** rw, |
There was a problem hiding this comment.
@{home_dirs) does not exist. Use: owner @{user_share_dirs}/certmagic/** rw,
apparmor.d/profiles-s-z/sing-box
Outdated
| /proc/meminfo r, | ||
| /sys/kernel/mm/transparent_hugepage/hpage_pmd_size r, | ||
|
|
||
| /usr/bin/tor mrix, |
| include <abstractions/ssl_certs> | ||
| include <abstractions/ssl_keys> | ||
| include <abstractions/tor> | ||
| include <abstractions/user-tmp> |
There was a problem hiding this comment.
This abstraction is quite board, can you restrict this a bit.
Yes, part of profile only work for me. Now my specific profile has been removed, only a generic scenario remains. |
roddhjav
force-pushed
the
main
branch
2 times, most recently
from
7e0f337 to
d3751d3
Compare
|
Thanks. Merged. For future contribution, please try to follow the profile guideline as I have done with 8f82547 |
https://github.com/SagerNet/sing-box
cc @nekohasekai