Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address mixed http https content #2 #13

Merged

Conversation

phillxnet
Copy link
Member

Following our move to https hosting we need to similarly normalise our links where possible. Especially where they are otherwise dysfunctional in more modern browsers due to mixed content protections.

Fixes #2

Includes:

  • fix typo in rockstor.com https link
  • move external shop.rockstor.com links to https
  • move remaining explicit external http links to https
  • remove unused http fonts.googleapis.com imports

Testing:

Prior to the changes presented here we had the following 'blocker' content that instigated the issue:

Blocked loading mixed active content “http://fonts.googleapis.com/css?family=Open+Sans:300italic,400italic,600italic,700italic,800italic,400,600,700,300,800”

Post proposed changes this error was not in evidence.

All modified pages/links were confirmed as displaying/linking as intended under an https hosting environment.

Includes:
- fix typo in rockstor.com https link
- move external shop.rockstor.com links to https
- move remaining explicit external http links to https
- remove unused http fonts.googleapis.com imports
@phillxnet
Copy link
Member Author

@FroggyFlox This pr is a little unusual as I required the live hosting environment to prove the 'fix'.

During these fix tests I brought our production server content much closer to what we have in this pr; still some stray files here and there but almost there now. So as post pr merge master branch will represents more closely what we have in production, and the proposed changes are relatively simplistic, I'm keen to simply merge this as-is and address any outstanding similar issues in a future issue/pr set.

Hopefully we can move soon to attempting proper reviews, pre production publish, once we have things properly lined up with this repo and it's production counterpart.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Address mixed http https content
1 participant