Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add README.md with rpm build instructions using official installer #2

Closed
phillxnet opened this issue Feb 20, 2023 · 1 comment
Closed

Add README.md with rpm build instructions using official installer #2

phillxnet opened this issue Feb 20, 2023 · 1 comment
Assignees
@phillxnet

Comments

@phillxnet
Copy link
Member

phillxnet commented Feb 20, 2023 •
edited
Loading

Our official downloadable installer, itself built using the https://github.com/rockstor/rockstor-installer repo, has all rpm build prerequisites preinstalled; bar currently wget, to be addressed in rockstor/rockstor-installer#133 "Proposal to add wget to our included packages".

It is proposed that we base our README.md contents around in-place rpm rebuilds to enable complete end-to-end testing if code changes in any relevant issue also require modifications in this repo. We also then have an easier path for domain experts to contribute improvements in this our initial Poetry build approach.

We should also mention in this repo-heading documentation that we mirror the master/testing branch structure of rockstor-core for, respectively the Stable and Testing channel updates. We are however on RC4 currently so will initially only have a testing branch in this repo with any significant contents.
@phillxnet phillxnet self-assigned this Feb 20, 2023
phillxnet added a commit to phillxnet/rockstor-rpmbuild that referenced this issue Feb 21, 2023
@phillxnet
Add README.md with rpm-build instructions rockstor#2
5b7140c 
Initial draft of developer focused About/Howto README.md.
Intended to enable contributors to do DIY RPM builds
for end-to-end testing of proposed changes in related
repositories. Based on using the official Rockstor
installer to promote self-hosting capabilities.
@phillxnet phillxnet mentioned this issue Feb 21, 2023
Merged
phillxnet added a commit that referenced this issue Feb 22, 2023
@phillxnet
Merge pull request #3 from phillxnet/2_Add_README.md_with_rpm_build_i…
db927b0 
…nstructions_using_official_installer

Add README.md with rpm-build instructions #2
@phillxnet
Copy link
Member Author

Closing as:
Fixed by #3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phillxnet phillxnet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@phillxnet