Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linkcheck cleanup (#490) #491

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

Hooverdan96
Copy link
Member

Fixes #490.

This pull request's proposal

Link cleanup/replacement where applicable, based on link checkup

Checklist

  • With the proposed changes no Sphinx errors or warnings are generated.
  • I have added my name to the AUTHORS file, if required (descending alphabetical order).

Fixes rockstor#490.
Link cleanup/replacement where applicable, based on link checkup
Copy link
Member

@phillxnet phillxnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Hooverdan96 Thanks again for your continued maintenance re our plethora of links. I think we should consider reducing our link density as it goes, i.e. as per the recently merged nginx Rock-on write up. We only really need to give a pointer of two to upstream projects, and then only to their canonical references: i.e. no need to also link in companies etc. We are not a link farm after all :) .

This branch looks to do what it said on the tin so I'll merge and get published shortly.

@phillxnet
Copy link
Member

Local build test

This branch only.

rediraffe: Redirect generation skipped for linkcheck builders.
build succeeded.
Look for any errors in the above output or in _build/linkcheck/output.txt
Link check complete; look for any errors in the above output  or in _build/linkcheck/output.txt.
program finished with exit code 0
elapsedTime=27.830662

@phillxnet phillxnet merged commit 5f7966f into rockstor:master Oct 7, 2024
3 checks passed
@phillxnet
Copy link
Member

PR product PRODUCTION published.

@Hooverdan96 Hooverdan96 deleted the 490_linkcheck_cleanup branch October 8, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolution of linkcheck issues
2 participants