Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Pre-Install Best Practice (PBP) #379 #395

Merged

Conversation

phillxnet
Copy link
Member

@phillxnet phillxnet commented Aug 27, 2022

Update and extend our PBP in line with our v4 focus.

Includes:

  • Remove v3 references re memtest86+ and replace with newer info.
  • Update currently failing/outdated memtest86+ download url.
  • Add a wipefs cmd component, re mdraid/LVM.
  • Move entire file to semantic formatting.

Fixes #379
Fixes #168

Checklist

  • With the proposed changes no Sphinx errors or warnings are generated.
  • I have added my name to the AUTHORS file, if required (descending alphabetical order).

Update and extend our PBP in line with our v4 focus.

## Includes:
- Remove v3 references re memtest86+ and replace with newer info.
- Update currently failing/outdated memtest86+ download url.
- Add a wipefs cmd component, re mdraid/LVM.
- Move entire file to semantic formatting.
@phillxnet
Copy link
Member Author

On reflection, our addition here of the wipfs instructions would be better placed in the referenced disk wipe section as they are not strictly 'regular' pre-install procedures. But given we also have pending:
#140
I'll add a note there to move both the new wipefs and mdraid PBP content to our wiping disks section.

@phillxnet
Copy link
Member Author

Merging what we have to date here as definitely an improvement.

@phillxnet phillxnet merged commit c94a906 into rockstor:master Aug 29, 2022
@phillxnet phillxnet deleted the 379_update_Pre-Install_Best_Practice_(PBP) branch August 29, 2022 12:52
@phillxnet
Copy link
Member Author

PR product production published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update Pre-Install Best Practice (PBP) add wipefs to wiping disks section PBP
1 participant