Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Django to latest 4.2 LTS #2750 #2752

Merged

Conversation

phillxnet
Copy link
Member

Update Django from 3.2.23 to 4.2.7 via poetry update and pyproject.toml.

Includes:

  • Move from django.utils.timezone utc to datetime.timezone.utc: RemovedInDjango50Warning
  • Remove to-be-deprecated USE_L10N setting, prior setting now enforced: RemovedInDjango50Warning
  • Add comment re Django 5.0 change in default USE_TZ value: Future default already adopted.
  • Comment STATICFILES_DIRS setting re build.sh & rockstor-jslibs.
  • Adopt new-in-Django-4.2 STORAGES setting to replace STATICFILES_STORAGE setting.

Fixes #2750

For development history see also draft PR #2751

Update Django from 3.2.23 to 4.2.7 via `poetry update`
and pyproject.toml.
## Includes:
- Move from django.utils.timezone utc to datetime.timezone.utc:
 RemovedInDjango50Warning
- Remove to-be-deprecated USE_L10N setting, prior setting now enforced:
 RemovedInDjango50Warning
- Add comment re Django 5.0 change in default USE_TZ value:
 Future default already adopted.
- Comment STATICFILES_DIRS setting re build.sh & rockstor-jslibs.
- Adopt new-in-Django-4.2 STORAGES setting to replace
 STATICFILES_STORAGE setting.
@phillxnet
Copy link
Member Author

As per development details in linked draft PR, these changes depend upon the current testing channel of rockstor-jslibs as we have the following merged, but not yet in-release tar, PR dependency:
Add socket.io.min.js.map file #39

@phillxnet
Copy link
Member Author

phillxnet commented Nov 20, 2023

Our rockstor-core PR test back-end fakes latest matched rockstor-jslibs repo branch, testing in this case, to allow for pre-tagged GitHub releases. Given this mechanism we have a successful rpmbuild and install of a test 5.0.5-2752 rpm (15.5 amd64 host), along with a preliminary Web-UI setup and basic/scant by-hand test under web browser development tools -> network -> disable cache to ensure we are using the rpm provided jslibs only.

The resulting install also rebooted successfully with all core rockstor services starting as expected.

@phillxnet
Copy link
Member Author

phillxnet commented Nov 20, 2023

@FroggyFlox & @Hooverdan96 I'll go ahead and merge this given the tests here and our unit tests executed during rpmbuild and the work done in the referenced draft PR. That jslibs issue was quite the surprise but we can re-approach that after we have our HTMX setup in place and are ready for Server Sent Events or the like.

Plus we need this in place as part of our ongoing Python updates, and related pending Poetry update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant