Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bro Log Retention Value Change & README simplification #345

Merged
merged 4 commits into from
Feb 13, 2019
Merged

Bro Log Retention Value Change & README simplification #345

merged 4 commits into from
Feb 13, 2019

Conversation

seven62
Copy link

@seven62 seven62 commented Jan 30, 2019

This PR consists of 2 changes:

  1. change the default bro_log_retention value from 0 to a more sane 168
  2. remove install steps from README.md and simplify by pointing to official docs

@dcode dcode changed the base branch from master to devel January 30, 2019 12:46
@dcode dcode changed the base branch from devel to master January 30, 2019 12:46
@dcode
Copy link
Member

dcode commented Jan 30, 2019

@seven62 bro_log_retention is used in the broctl.cfg template and is specified in days. What's special about 168 days of logs? I assume you were making some correlation to the Kafka retention, which is in hours, which would make retention of 7 days. It could be that the variable naming is confusing, in which case maybe we address that too.

@seven62
Copy link
Author

seven62 commented Jan 30, 2019

@dcode thanks for the clarification. I submitted a new default of 168 thinking that it was hours rather than days. I think 7 days is a better starting point, especially for an Auto install. Adjusting PR.

@dcode dcode merged commit d38729f into rocknsm:master Feb 13, 2019
@dcode dcode mentioned this pull request Feb 22, 2019
dcode added a commit that referenced this pull request Feb 22, 2019
* New: Add ability to do multi-host deployment of sensor + data tiers (#339, [bndabbs@gmail.com](mailto:bndabbs@gmail.com))
* New: Integrate Docket into Kibana by default ([derek@rocknsm.io](mailto:derek@rocknsm.io))
* New: Improvements and additional Kibana dashboards (spartan782)
* Fixes: issue with Bro failing when monitor interface is down (#343, [bndabbs@gmail.com](mailto:bndabbs@gmail.com))
* Fixes: issue with services starting that shouldn’t (#346, [therealneu5ron@gmail.com](mailto:therealneu5ron@gmail.com))
* Fixes: race condition on loading dashboards into Kibana (#356, [derek@rocknsm.io](mailto:derek@rocknsm.io))
* Fixes: configuration for Docket allowing serving from non-root URI (#361, [derek@rocknsm.io](mailto:derek@rocknsm.io))
* Change: bro log retention value to one week rather than forever (#345, [sean.cochran@gmail.com](mailto:sean.cochran@gmail.com))
* Change: Greatly improve documentation  (#338, [sean.cochran@gmail.com](mailto:sean.cochran@gmail.com))
* Change: Reorganize README (#308, [bradford.dabbs@elastic.co](mailto:bradford.dabbs@elastic.co))
* Change: Move ECS to rock-dashboards repo (#305, [derek@rocknsm.io](mailto:derek@rocknsm.io))
* Change: Move RockNSM install paths to filesystem heirarchy standard locations (#344, [bndabbs@gmail.com](mailto:bndabbs@gmail.com))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants