WX's Portfolio Page #92
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flashrob
reviewed
Oct 23, 2024
| </head> | ||
| <body> | ||
| <h1>Hello, world!</h1> | ||
| <!-- Navigation Bar --> | ||
| <div class="navbar"> |
| I aspire to design and build beautiful websites for businesses | ||
| around the globe. If you need a modern and powerful website, simply | ||
| send me an | ||
| <span style="color: hsl(40, 95%, 54%)">email</span> or visit my |
There was a problem hiding this comment.
let's try to use css files for such styles
| send me an | ||
| <span style="color: hsl(40, 95%, 54%)">email</span> or visit my | ||
| <span style="color: hsl(40, 95%, 54%)">Linkedin profile</span>. | ||
| <div id="discover-btn"> |
There was a problem hiding this comment.
why not use a button, if it is supposed to be a button?
| <h1>Recipe Site</h1></a> | ||
| <p><i>A website design created to store recipes.</i></p> | ||
| <p>October 2024</p> | ||
| <p><a href="https://wenxin-p.github.io/recipe-site-bootcamp/index.html"><u>Visit Site</u></p></a> |
There was a problem hiding this comment.
we could use css instead of the u tag, both works though
| <div class="flip-card"> | ||
| <div class="flip-card-inner"> | ||
| <div class="flip-card-front"> | ||
| <img src="Coming Soon Logo.jpg" alt="Coming Soon" style="width:300px;height:200px;"> |
There was a problem hiding this comment.
let's avoid inline styles like here and use css. Alternatively you could just use the width and heigth attribute on an img tag
|
|
||
| <!-- The flexible grid (content) --> | ||
| <div class="main-container"> | ||
| <h1>MY PROJECTS.</h1> |
There was a problem hiding this comment.
what's the difference between portfolio.html and index.html?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.