Qianling - Portfolio page #71
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inks to the left and added button element to the right
Flashrob
reviewed
Oct 9, 2023
Comment on lines
+36
to
+37
|
|
||
|
|
There was a problem hiding this comment.
this whitespace looks odd, let's remove it :)!
|
|
||
| <div class="about"> | ||
| <p class="title"> | ||
| Hey there, I'm Qianling! <br />An aspiring Software Engineer. |
There was a problem hiding this comment.
Personally I am not the biggest fan of <br />. I would rather make another <p> and use margins to create the desired distance between the lines
|
|
||
| </p> | ||
| <div> | ||
| <button class="say-hello-button">Let's Start ></button> |
There was a problem hiding this comment.
You could try seeing if we need the <div> without much of a use. Can we make in-line elements to block elements? :)
| <h2 class="footer-header">Contact</h2> | ||
| <div class="contact"> | ||
| <a href="https://github.com"><img src = "github.png" alt="github-logo"></a> | ||
|
|
| <div class="contact"> | ||
| <a href="https://github.com"><img src = "github.png" alt="github-logo"></a> | ||
|
|
||
| <a href="https://www.linkedin.com" target="blank"><img src = "linkedin.png" alt="linkedin-logo"></a> |
There was a problem hiding this comment.
I think we could break this into multiple lines to make it more readable
| margin: 0; | ||
| } | ||
|
|
||
| /* header section */ |
There was a problem hiding this comment.
this comment is somewhat redundant as the class name is self-explanatory
| font-family: "Segoe UI", Tahoma, Geneva, Verdana, sans-serif; | ||
| } | ||
|
|
||
| /* home section */ |
| background-color: whitesmoke; | ||
| } | ||
|
|
||
| /* project section */ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.