update script #12
Open
update script #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flashrob
reviewed
Oct 29, 2024
Comment on lines
+17
to
+18
| const [p1RoundsWon, setp1RoundWon] = useState(0); | ||
| const [p2RoundsWon, setp2RoundWon] = useState(0); |
There was a problem hiding this comment.
Do you think we can use a single state variable for player 1 and 2?
src/App.jsx
Outdated
Comment on lines
27
to
34
| if (newCurrCards[0].rank > newCurrCards[1].rank) { | ||
| const newP1Score = p1RoundsWon + 1; | ||
| setp1RoundWon(newP1Score); | ||
| } | ||
| if (newCurrCards[0].rank < newCurrCards[1].rank) { | ||
| const newP2Score = p2RoundsWon + 1; | ||
| setp2RoundWon(newP2Score); | ||
| } |
There was a problem hiding this comment.
What would happen if your deck goes down to 0 cards?
Comment on lines
+87
to
+113
| <Row> | ||
| <Col className="column">Player 1 drew {currCardElems[0]}</Col> | ||
| <Col className="column">and</Col> | ||
| <Col className="column">Player 2 drew {currCardElems[1]}</Col> | ||
| </Row> | ||
| <Row> | ||
| <Col className="column">Player 1 Score</Col> | ||
| <Col className="column">vs.</Col> | ||
| <Col className="column">Player 2 Score</Col> | ||
| </Row> | ||
| <Row> | ||
| <Col className="column">{p1RoundsWon}</Col> | ||
| <Col className="column">vs.</Col> | ||
| <Col className="column">{p2RoundsWon}</Col> | ||
| </Row> | ||
| <Row> | ||
| <Col className="column"> | ||
| <Button variant="primary" onClick={dealCards}> | ||
| {ButtonText1} | ||
| </Button> | ||
| </Col> | ||
| <Col className="column"> | ||
| <Button variant="secondary" onClick={handleReset}> | ||
| {ButtonText} | ||
| </Button> | ||
| </Col> | ||
| </Row> |
There was a problem hiding this comment.
I think you do have some opportunity here to create components for the repeating elements. By not doing that, your App component is getting a bit messy
Co-authored-by: Flashrob <38381396+Flashrob@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.