Marina's Bigfoot JSON frontend #37
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flashrob
reviewed
Mar 8, 2024
Comment on lines
+19
to
+22
| linkStyle = { | ||
| textDecoration: "none", | ||
| color: "white", | ||
| }; |
Comment on lines
+7
to
+8
| const form = e.target; | ||
| const query = form.search.value; |
There was a problem hiding this comment.
why not e.target.form.search.value? :D
Comment on lines
+10
to
+14
| if (isNaN(query)) { | ||
| props.setSearchParams({ state: query }); | ||
| } else { | ||
| props.setSearchParams({ year: query }); | ||
| } |
There was a problem hiding this comment.
not bad, validating data type here. But why is NaN equal to state?
Comment on lines
+24
to
+27
| display: "flex", | ||
| justifyContent: "center", | ||
| marginTop: 3, | ||
| marginBottom: 3, |
| const fetchSightingData = async () => { | ||
| try { | ||
| const data = await axios.get( | ||
| `${BACKEND_URL}/sightings/${REPORT_NUMBER}` |
There was a problem hiding this comment.
what if report number is undefined or a number? you will still make a request
Comment on lines
+20
to
+29
| const query = {}; | ||
| if (stateQuery) { | ||
| query.state = stateQuery; | ||
| } | ||
| if (yearQuery) { | ||
| query.year = yearQuery; | ||
| } | ||
| const { data } = await axios.get(`${BACKEND_URL}/sightings`, { | ||
| params: query, | ||
| }); |
There was a problem hiding this comment.
Suggested change
| const query = {}; | |
| if (stateQuery) { | |
| query.state = stateQuery; | |
| } | |
| if (yearQuery) { | |
| query.year = yearQuery; | |
| } | |
| const { data } = await axios.get(`${BACKEND_URL}/sightings`, { | |
| params: query, | |
| }); | |
| const { data } = await axios.get(`${BACKEND_URL}/sightings`, { | |
| params: { | |
| ...(stateQuery && { state: stateQuery}), | |
| ...(yearQuery && {year: yearQuery}), | |
| }, | |
| }); |
| fetchData(); | ||
| }, [stateQuery, yearQuery]); | ||
|
|
||
| console.log(sightings); |
| <Card sx={{ marginBottom: 3, width: 300 }}> | ||
| <CardContent sx={{ display: "flex", justifyContent: "flex-start" }}> | ||
| <p> | ||
| {index + 1}. {sighting.STATE} {sighting.YEAR} |
There was a problem hiding this comment.
the index + 1 doesnt make much sense here. Would put into variable
Comment on lines
+42
to
+57
| <Link to={`./${sighting.REPORT_NUMBER}`} key={index}> | ||
| <Container | ||
| sx={{ | ||
| display: "flex", | ||
| justifyContent: "center", | ||
| }} | ||
| > | ||
| <Card sx={{ marginBottom: 3, width: 300 }}> | ||
| <CardContent sx={{ display: "flex", justifyContent: "flex-start" }}> | ||
| <p> | ||
| {index + 1}. {sighting.STATE} {sighting.YEAR} | ||
| </p> | ||
| </CardContent> | ||
| </Card> | ||
| </Container> | ||
| </Link> |
There was a problem hiding this comment.
Should make this whole thing a component
| </Card> | ||
| </Container> | ||
| </Link> | ||
| ) : null |
There was a problem hiding this comment.
no need for ternary operator when using null for else. Just use && shorthand
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.