PTBC9 - Patrick #34
Open
PTBC9 - Patrick #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ual sighting pages
…s page, minor bugfix
Flashrob
reviewed
Mar 8, 2024
| useEffect(() => { | ||
| const getSightings = async () => { | ||
| const freshSightings = await fetch(BACKEND_URL + "/sightings", { | ||
| method: "get", |
There was a problem hiding this comment.
I think get is the default for the fetch API, so redundant to add this
Comment on lines
+23
to
+26
| const id = sighting.id; | ||
| const date = sighting.date; | ||
| const location = sighting.location; | ||
| const categories = sighting.categories; |
There was a problem hiding this comment.
const { id, date, location, categories } = sighting;
easier
| })); | ||
|
|
||
| setCategoryOptions(newCategoryOptions); | ||
| console.log(categoryOptions); |
| }; | ||
| const handleSelectChange = (e) => { | ||
| const categoriesArr = e.map((obj) => obj.value); | ||
| console.log(categoriesArr); |
| e.preventDefault(); | ||
| const addNewSighting = async () => { | ||
| const categoriesArr = selectFields.map((obj) => obj.value); | ||
| await fetch(BACKEND_URL + "/sightings/", { |
| body: JSON.stringify({ input: inputFields, categories: categoriesArr }), | ||
| }) | ||
| .then((response) => response.json()) | ||
| .then((data) => console.log(data)); |
There was a problem hiding this comment.
why use promise and all if you just console.log in the end? Usually you would need to update the list of sightings after creating a new one
| type="text" | ||
| value={inputFields.date} | ||
| onChange={(e) => handleChange(e, "date")} | ||
| ></input> |
| const { int } = useParams(); | ||
|
|
||
| const fetchComments = async () => { | ||
| const fetchedComments = await fetch(BACKEND_URL + "/comments/" + int, { |
| method: "get", | ||
| }); | ||
| const fetchedCommentsJson = await fetchedComments.json(); | ||
| setComments([...fetchedCommentsJson]); |
There was a problem hiding this comment.
why not just setComments(fetchedCommentsJson) ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.