test: test edge trigger property with init: true connection #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the edge triggered functionality only really works when the edge_triggered_output flag is true and the connection has the `init: true` flag, so the keep_last_written_value can be kept as true by default without major drawbacks.
eduardacoppo
force-pushed
the
test_edge_trigger_property
branch
2 times, most recently
from
c863471 to
2096cfe
Compare
organize tests into general functionality and tests for init: true, which need a particular setup the "fails to configure if a GPIO does not exist" was duplicated
eduardacoppo
force-pushed
the
test_edge_trigger_property
branch
from
2096cfe to
ccb72ba
Compare
doudou
approved these changes
Feb 4, 2025
fixes the break_and_reestablish_connection function gives better and more descriptive names to the tasks simplifies tests code cleaning in general
jhonasiv
approved these changes
Feb 5, 2025
doudou
approved these changes
Feb 6, 2025
|
@eduardacoppo fala comigo quando os testes passaram, acho que eu tenho de fazer merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for
When pure input GPIOs are edge-triggered, we don't get updates regularly, which makes any dynamic connection to it inoperable. I.e. a reader that is created while the task is running won't get the current state of the I/O
This task is to make sure that it would work with init: true. This policy flag requests that the connection sends the last value written to it, but it requires changes on the component side (the ports need to be configured to save said last value).
This PR tests this setup