feat(zbugs): support mermaid diagrams #2751
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tantaman
commented
Oct 21, 2024
tantaman
force-pushed
the
mlaw/mermaid
branch
from
7c3210d to
04462eb
Compare
tantaman
force-pushed
the
mlaw/mermaid
branch
from
04462eb to
19631ea
Compare
tantaman
force-pushed
the
mlaw/mermaid
branch
from
19631ea to
e7fe259
Compare
tantaman
force-pushed
the
mlaw/mermaid
branch
from
e7fe259 to
4973ed8
Compare
tantaman
force-pushed
the
mlaw/mermaid
branch
from
cde6a91 to
b8dbf4d
Compare
|
will come back to this some other time. seems fine but eslint fails to execute 🤷♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So we're not cavemen trying to diagram in ASCII.
Before:
After:
Mermaid diagrams will cause a layout shift because they load async but I think that's a reasonable tradeoff given the library size (~1mb)
CleanShot.2024-10-25.at.10.11.18.mp4