Merge pull request #174 from alimy/jc/alimy

optimize localossObject implement logic
rocboss · Jul 26, 2022 · cd4b754 · cd4b754
2 parents ec615b6 + 8c32ff9
commit cd4b754
Showing 1 changed file with 9 additions and 2 deletions.
diff --git a/internal/dao/storage/localoss.go b/internal/dao/storage/localoss.go
@@ -118,17 +118,24 @@ func (s *localossCreateTempDirServant) PersistObject(objectKey string) error {
 	if err != nil {
 		return err
 	}
+	needCloseReader := true
+	defer func() {
+		if needCloseReader {
+			reader.Close()
+		}
+	}()
+
 	writer, err := os.Create(s.savePath + objectKey)
 	if err != nil {
 		return err
 	}
 	defer writer.Close()
 	if _, err = io.Copy(writer, reader); err != nil {
-		reader.Close()
 		return err
 	}
-	reader.Close()
 
+	reader.Close()
+	needCloseReader = false
 	if err = os.Remove(tmpObjPath); err != nil {
 		return err
 	}