Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix install location of pkgconfig file #21

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

daissi
Copy link
Contributor

@daissi daissi commented Aug 8, 2024

This file contains architecture specific dir (for instance on x86_64 : libdir=/usr/lib/x86_64-linux-gnu), so it needs to be installed in a multi-arch path. This patch is applied in the debian package.

This file contains architecture specific dir, so it needs to be installed
in a multi-arch path.
@gavv
Copy link
Member

gavv commented Aug 12, 2024

Thanks!

Can we use CMAKE_INSTALL_FULL_LIBDIR instead of CMAKE_INSTALL_LIBDIR for consistency with the rest cmake scripts?

@gavv gavv merged commit 4b21d40 into roc-streaming:main Aug 12, 2024
3 checks passed
@gavv
Copy link
Member

gavv commented Aug 12, 2024

I've changed it to CMAKE_INSTALL_FULL_LIBDIR, but let me know if we need to revert it.

@gavv
Copy link
Member

gavv commented Aug 12, 2024

@daissi
Copy link
Contributor Author

daissi commented Aug 12, 2024

I've changed it to CMAKE_INSTALL_FULL_LIBDIR, but let me know if we need to revert it.

Thanks! It works too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants