Skip to content
This repository has been archived by the owner on May 10, 2023. It is now read-only.

IE8 fallback not added if IE9 or 10 are also in the browser option #54

Closed
bob2021 opened this issue May 14, 2016 · 3 comments
Closed

IE8 fallback not added if IE9 or 10 are also in the browser option #54

bob2021 opened this issue May 14, 2016 · 3 comments

Comments

@bob2021
Copy link

bob2021 commented May 14, 2016

If I apply pixrem to this css:

a { font-size: 0.75rem; }

I would expect a fallback to be added for IE >= 8, but not IE >= 9.

If I specify 'ie 8' in the browser option then everything works ok, but if I specify 'ie >= 8' then the fallback is not added.

@iamvdo
Copy link
Collaborator

iamvdo commented May 17, 2016

Could not reproduce.
ie 8 or ie >= 8 produce same result.

Be sure to check your workflow (minifer, etc.)

@iamvdo iamvdo closed this as completed May 17, 2016
@bob2021
Copy link
Author

bob2021 commented May 23, 2016

I have double checked but I am still getting different results - here's the script I'm using to test:

'use strict';
var pixrem  = require('pixrem');
var postcss = require('postcss');

var css = 'h1 { font-size: 1rem; }';
var processedCss = '';

processedCss = postcss([pixrem({
    browsers: 'ie >= 8'
})]).process(css).css;
console.log(processedCss);

processedCss = postcss([pixrem({
    browsers: 'ie 8'
})]).process(css).css;
console.log(processedCss);

// Expected output:
// h1 { font-size: 16px; font-size: 1rem; }
// h1 { font-size: 16px; font-size: 1rem; }

// Actual output:
// h1 { font-size: 1rem; }
// h1 { font-size: 16px; font-size: 1rem; }

If you could take another look or point out what I'm doing wrong it would be much appreciated. I'm using pixrem version 3.0.0

Thanks

@iamvdo
Copy link
Collaborator

iamvdo commented May 24, 2016

Sorry, there was a bug. Fixed and released as 3.0.1
Thanks 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants