Centralized multi-cluster Prometheus/Thanos/VM support

[Avi-Robusta]

we require the user to add the label when running krr on multi-cluster centeralized prometheus
example of the new command:
python3.9 krr.py simple -p http://PROM_URL:9090 -l prod-eu-cluster
When a label is not specified you get this error:
[ERROR] KRR requires a prometheus_cluster_label to run your query, please select one of the following clusters ['CLUSTER_1_NAME', 'CLUSTER_2_NAME']

if the cluster label doesn't exist you get the following error:
[ERROR] prometheus_cluster_label bad-cluster-name does not exist, please use one of the following ['CLUSTER_1_NAME', 'CLUSTER_2_NAME']

[aantn]

Avi, can we explicitly name the command line parameter in the error message. E.g: Rerun krr with the flag `-l <cluster>` where <cluster> is one of...

…

On Tue, Jun 13, 2023, 19:11 Avi-Robusta ***@***.***> wrote: we require the user to add the label when running krr on multi-cluster centeralized prometheus example of the new command: python3.9 krr.py simple -p http://PROM_URL:9090 -l prod-eu-cluster When a label is not specified you get this error: [ERROR] KRR requires a prometheus_cluster_label to run your query, please select one of the following clusters ['CLUSTER_1_NAME', 'CLUSTER_2_NAME'] if the cluster label doesn't exist you get the following error: [ERROR] prometheus_cluster_label bad-cluster-name does not exist, please use one of the following ['CLUSTER_1_NAME', 'CLUSTER_2_NAME'] ------------------------------ You can view, comment on, or merge this pull request online at: #70 Commit Summary - d326e96 <d326e96> added cluster name param for centralized support - 16184a3 <16184a3> Bad cluster label exception - 8d9d0ba <8d9d0ba> removed stack trace for ClusterNotSpecifiedException File Changes (10 files <https://github.com/robusta-dev/krr/pull/70/files>) - *M* robusta_krr/core/integrations/prometheus/__init__.py <https://github.com/robusta-dev/krr/pull/70/files#diff-9d7910194b05de0a50bc78afff1253754454cb108b55cb7f5ea32d34a8c347d8> (2) - *M* robusta_krr/core/integrations/prometheus/loader.py <https://github.com/robusta-dev/krr/pull/70/files#diff-ebbf0dc4d3c515c68522716247f1635d513e75c23c6ccdd64303c47c0e686891> (1) - *M* robusta_krr/core/integrations/prometheus/metrics/base_metric.py <https://github.com/robusta-dev/krr/pull/70/files#diff-74a414326668a9e8ba0e69da0b13eebc7d9821ccf8a1cf1d2f73701687f370ad> (11) - *M* robusta_krr/core/integrations/prometheus/metrics/cpu_metric.py <https://github.com/robusta-dev/krr/pull/70/files#diff-30e6f78d8b831460c278d2f8c1c19ab49ce017d6a060c946e2a6e5c638fc537c> (2) - *M* robusta_krr/core/integrations/prometheus/metrics/memory_metric.py <https://github.com/robusta-dev/krr/pull/70/files#diff-28b104aa3fd9132df12d427cbaf73f0cb9a14ef7f2b395d3d203036884d2bd02> (2) - *M* robusta_krr/core/integrations/prometheus/metrics_service/base_metric_service.py <https://github.com/robusta-dev/krr/pull/70/files#diff-8f969c940bd2522d2b8f88ad25e98cadb3e7d0e97bde9a40b26de8a3bc839519> (6) - *M* robusta_krr/core/integrations/prometheus/metrics_service/prometheus_metrics_service.py <https://github.com/robusta-dev/krr/pull/70/files#diff-b65b314ab525c60f5c27bf7fab7615398d6a023a562ac950757e35e0fc323246> (29) - *M* robusta_krr/core/models/config.py <https://github.com/robusta-dev/krr/pull/70/files#diff-1b1529e11e489ff2e5f954a8e1539be9d4e0be9a8cb5d83820aeaccea1c00f0f> (1) - *M* robusta_krr/core/runner.py <https://github.com/robusta-dev/krr/pull/70/files#diff-92c64d64648a3c1c9877fc84856b02e0ae83f441a32a7e4920adbeb84d05a361> (12) - *M* robusta_krr/main.py <https://github.com/robusta-dev/krr/pull/70/files#diff-4c94a8066fdb7a036fc6a9225e6789054100168097f1df04007b33d454b63946> (8) Patch Links: - https://github.com/robusta-dev/krr/pull/70.patch - https://github.com/robusta-dev/krr/pull/70.diff — Reply to this email directly, view it on GitHub <#70>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADYUB75B4MC2IZ5ZQSPP2TXLCGMRANCNFSM6AAAAAAZFD5LUI> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>