Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table: allow striped + expandable #607

Merged
merged 3 commits into from
Sep 11, 2024

Conversation

djoks
Copy link
Contributor

@djoks djoks commented Sep 6, 2024

  • Fixed issue with zebra striping not being applied to table when rows are expandable.
  • Updated nth-child selectors to correctly handle every 4th and 3rd rows.
  • Resolved conflicts between hover states and expanded rows using dynamic ::class and class bindings.

Bug Report:

MaryUI version: ^1.20
Livewire version: ^3.5

Affected Browsers:

  • Chrome
  • Firefox
  • Safari
  • Edge

What Happened?

  • Zebra Striping Issue: Rows with the expandable feature were affected by zebra striping, causing inconsistent row styling, particularly on hover.

Screencast:

mary-ui-djoks-fix-table-zebra-expandable.mp4

@djoks
Copy link
Contributor Author

djoks commented Sep 7, 2024

@robsontenorio I implemented a fix for this using arbitrary values and variants in Tailwindcss. Please check it out.

@robsontenorio robsontenorio changed the title fix(table): resolve zebra stripe and expandable row styling conflicts Table: allow striped + expandable Sep 11, 2024
@robsontenorio
Copy link
Owner

Thanks!

I simplified the implementation to keep the same behavior expected for expanded style and use daisyUI utility classes instead of raw CSS variables.

@robsontenorio robsontenorio merged commit 248a238 into robsontenorio:main Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants