Add error handling for stream iterators #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaacovCR
force-pushed
the
stream-errors
branch
2 times, most recently
from
afa63e7 to
18b5bf5
Compare
robrichard
reviewed
Nov 18, 2022
spec/Section 6 -- Execution.md
Outdated
| - Add an entry to {payload} named `items` with the value {null}. | ||
| - Add an entry to {payload} named `errors` with the value {errors}. |
There was a problem hiding this comment.
Can we move these two lines down so it's not repeated in both conditions?
There was a problem hiding this comment.
Hmm, lower down, we have conditions on adding those entries, but when the iterator errors, we don't have conditions. There may be a way to consolidate that I haven't thought of, though.
There was a problem hiding this comment.
Can we delete this line and move this
- If {errors} is not empty:
- Add an entry to {payload} named `errors` with the value {errors}.
to outside of the Otherwise: block?
robrichard
pushed a commit
that referenced
this pull request
Jan 15, 2023
* Add error handling for stream iterators * also add iterator error handling within CompleteValue * incorporate feedback
robrichard
pushed a commit
that referenced
this pull request
Aug 31, 2023
* Add error handling for stream iterators * also add iterator error handling within CompleteValue * incorporate feedback
robrichard
added a commit
that referenced
this pull request
Sep 18, 2024
* Add defer and stream directives to type system * Add defer/stream validation rules
robrichard
added a commit
that referenced
this pull request
Nov 1, 2024
* Add defer and stream directives to type system * Add defer/stream validation rules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This diff looks smaller when ignoring white space :)