-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RawFrame to autogen_headers #124
Conversation
Why is wpi__RawFrame.hpp trying to include |
It's seeing the |
Oh interesting. Do I have any way around that? I could just add manual pybind code to the module definition in main.cpp, since it looks like that's true even if I try to add inline code? Or what should I do? |
You could try adding |
How would I get robotpy to ignore everything except for the WPI_TimestampSource enum? Can I do that in the class' YAML? |
Looks like spam |
Oh right, just remembered we have |
I don't think it makes sense to quote yet. RawFrame is a thin wrapper around a C array of image data - i'm not sure there's a great way (or even a reason yet?) to wrap it in a numpy array for use with opencv stuff. Might be cool to think about in the future though! Either way, if this is merged, CI on wpilibsuite/allwpilib#7609 should become green :) |
This comment has been minimized.
This comment has been minimized.
That's fine, but in the future there's also defaults.ignore:
|
|
||
enums: | ||
WPI_PixelFormat: | ||
ignore: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Guessing not worth exposing this enum to Python, since there's an equivalent C++ enum in cscore
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I read it yes, the cscore side enum is what the rest of cscore uses in its public api, not the RawFrame version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Companion to wpilibsuite/allwpilib#7609