-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Findassimp.cmake in Ubuntu 20.04 and 18.04 #373
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I'll wait for @randaz81 before merging
@traversaro I think this should be on the ycm-0.12 branch, though |
Unfortunately, the PR seems not to be enough to fix my issue. |
Yes, the branch was already based on that, it was just the PR that was wrong, I fixed it now. |
Based on #224 (comment) I added another fix for another affected library. Anyhow, probably we need to make sure that this was working before PR #371 (comment), otherwise probably the source of the problem is another. |
I can confirm that the new commit fixes the issues 👍 |
Merged, thanks. |
Unfortunately what discussed in #371 (comment) turned out to be true.
In particular, if I understood correctly (still needs to be confirmed) @randaz81 is having problem in https://github.com/robotology/cer due to the specific order of
find_package(YCM)
andfind_package(gazebo)
calls (gazebo's CMake config file calls DART's CMake config file that callsfind_package(assimp)
, whose behavior change depending of weatherfind_package(YCM)
was called or not). While this could be probably fixed by movingfind_package(gazebo)
beforefind_package(YCM)
, this PR should provide a more robust fix by having a logic to detect the malformed assimp configuration file of Ubuntu 20.04 and fixing it.cc @randaz81 if you could test this it would be great.