Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Findassimp.cmake in Ubuntu 20.04 and 18.04 #373

Merged
merged 2 commits into from
Mar 1, 2021
Merged

Conversation

traversaro
Copy link
Member

Unfortunately what discussed in #371 (comment) turned out to be true.

In particular, if I understood correctly (still needs to be confirmed) @randaz81 is having problem in https://github.com/robotology/cer due to the specific order of find_package(YCM) and find_package(gazebo) calls (gazebo's CMake config file calls DART's CMake config file that calls find_package(assimp) , whose behavior change depending of weather find_package(YCM) was called or not). While this could be probably fixed by moving find_package(gazebo) before find_package(YCM), this PR should provide a more robust fix by having a logic to detect the malformed assimp configuration file of Ubuntu 20.04 and fixing it.

cc @randaz81 if you could test this it would be great.

Copy link
Member

@drdanz drdanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'll wait for @randaz81 before merging

@drdanz
Copy link
Member

drdanz commented Mar 1, 2021

@traversaro I think this should be on the ycm-0.12 branch, though

@randaz81
Copy link
Member

randaz81 commented Mar 1, 2021

Unfortunately, the PR seems not to be enough to fix my issue.
BTW, I'm not using Ubuntu 20.04, I am working on a docker image nvidia/cuda:10.0-cudnn7-devel which is based on Ubuntu 18.04

@traversaro traversaro changed the base branch from master to ycm-0.12 March 1, 2021 13:16
@traversaro
Copy link
Member Author

@traversaro I think this should be on the ycm-0.12 branch, though

Yes, the branch was already based on that, it was just the PR that was wrong, I fixed it now.

@traversaro traversaro changed the title Fix Findassimp.cmake in Ubuntu 20.04 Fix Findassimp.cmake in Ubuntu 20.04 and 18.04 Mar 1, 2021
@traversaro
Copy link
Member Author

Unfortunately, the PR seems not to be enough to fix my issue.
BTW, I'm not using Ubuntu 20.04, I am working on a docker image nvidia/cuda:10.0-cudnn7-devel which is based on Ubuntu 18.04

Based on #224 (comment) I added another fix for another affected library. Anyhow, probably we need to make sure that this was working before PR #371 (comment), otherwise probably the source of the problem is another.

@randaz81
Copy link
Member

randaz81 commented Mar 1, 2021

I can confirm that the new commit fixes the issues 👍

@drdanz drdanz merged commit dc98072 into ycm-0.12 Mar 1, 2021
@drdanz drdanz deleted the fix-ubuntu-20-04 branch March 1, 2021 17:08
@drdanz
Copy link
Member

drdanz commented Mar 1, 2021

Merged, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants