-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
controlBoardRemapper: align the mandatory interfaces to controlBoard_nws_yarp #3095
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update the release notes by adding a file in |
Done: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to me that the not-mandatory interfaces are not adequately protected elsewhere.
For example, if vel
interface is now optional, it must have a guard if (ivel!=nullptr)
in ControlBoardRemapper.cpp to prevent a segfault if a client is calling it
I'd suggest also to add a new test, which attaches to |
2591ed8
to
a6d5fbc
Compare
@randaz81 @traversaro I added all the safeguards for those interfaces that are not mandatory anymore. |
Quality Gate failedFailed conditions |
As per
controlBoard_nws_yarp
it is mandatory only that at list is implementediAxisInfo
ORiPositionControl
.