Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

controlBoardRemapper: align the mandatory interfaces to controlBoard_nws_yarp #3095

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

Nicogene
Copy link
Member

As per controlBoard_nws_yarp it is mandatory only that at list is implemented iAxisInfo OR iPositionControl.

@Nicogene Nicogene self-assigned this Mar 18, 2024
Copy link

update-docs bot commented Mar 18, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update the release notes by adding a file in doc/release/<target_branch>, based on your changes.

traversaro
traversaro previously approved these changes Mar 18, 2024
@Nicogene
Copy link
Member Author

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update the release notes by adding a file in doc/release/<target_branch>, based on your changes.

Done:

Copy link
Member

@randaz81 randaz81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to me that the not-mandatory interfaces are not adequately protected elsewhere.
For example, if vel interface is now optional, it must have a guard if (ivel!=nullptr) in ControlBoardRemapper.cpp to prevent a segfault if a client is calling it

@randaz81
Copy link
Member

randaz81 commented Apr 2, 2024

I'd suggest also to add a new test, which attaches to fakeMotionControlMicro instead of fakeMotionControl.
This because fakeMotionControl actually implements all interfaces, so the current test cannot catch any issue if the remapper is used with a device that does not implement all interfaces.

@Nicogene Nicogene force-pushed the reduceIntRemapper branch from 2591ed8 to a6d5fbc Compare April 4, 2024 13:38
@Nicogene Nicogene requested review from randaz81 and traversaro April 4, 2024 13:39
@Nicogene
Copy link
Member Author

Nicogene commented Apr 4, 2024

@randaz81 @traversaro I added all the safeguards for those interfaces that are not mandatory anymore.
Moreover, I added a test on the fakeMotionControlMicro in order to check these new changes, finally I successfully tested the controlBoardRemapper in simulation.

Copy link

sonarqubecloud bot commented Apr 4, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
42.9% Coverage on New Code (required ≥ 80%)
41.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@randaz81 randaz81 merged commit e4762b0 into robotology:master Apr 8, 2024
49 of 50 checks passed
@Nicogene Nicogene deleted the reduceIntRemapper branch April 8, 2024 13:13
@randaz81 randaz81 added this to the YARP 3.10.0 milestone Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants