Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move realsense2 YARP devices to a separate standalone repository. #2371

Closed
drdanz opened this issue Sep 25, 2020 · 8 comments · Fixed by #2383
Closed

Move realsense2 YARP devices to a separate standalone repository. #2371

drdanz opened this issue Sep 25, 2020 · 8 comments · Fixed by #2383
Assignees

Comments

@drdanz
Copy link
Member

drdanz commented Sep 25, 2020

The realsense2 device depends on the realsense2 library that is not available by default in debian/ubuntu.
In order to simplify the installation using binary packages, we should move this device in a separate repository.

@drdanz drdanz added Component: CMake Type: Task This is some task that does fall into the other "Types" Component: Devices labels Sep 25, 2020
@drdanz
Copy link
Member Author

drdanz commented Sep 25, 2020

I imported the realsense2 device here:
https://github.com/robotology/yarp-device-realsense2

There are probably still a couple of things to fix, but the code is officially there, and the src/devices/realsense2 in YARP is therefore frozen.
Also the documentation in doc/subdevice_realsense.md, should probably be moved in the new repository (cc @aikolina)

I will remove it from YARP as soon as I am sure that it works properly.

@xEnVrE
Copy link
Contributor

xEnVrE commented Oct 7, 2020

I will remove it from YARP as soon as I am sure that it works properly.

Fyi, I tested the new repository and everything seems ok. I tested with a D415 only.

realsense

@drdanz
Copy link
Member Author

drdanz commented Oct 7, 2020

Thanks @xEnVrE for testing!

@PeterBowman
Copy link
Member

Also successfully tested with a D435i (realsense2 device), YARP 3.4.1, RealSense SDK 2.39.0.

@drdanz
Copy link
Member Author

drdanz commented Oct 12, 2020

Thanks @PeterBowman
I think we are ready to remove the driver from master then...

@drdanz
Copy link
Member Author

drdanz commented Oct 12, 2020

Also the documentation in doc/subdevice_realsense.md, should probably be moved in the new repository

We should still figure out what to do with this documentation page, since if we move it out of YARP it will no longer be generated, but it doesn't make sense to leave it there, since the device is no longer there.
Perhaps we can convert it to markdown, and adapt it to be the README.md file in the new repository?

@traversaro
Copy link
Member

For small repos, a well written README is definitely the most accessible and maintainable form of documentation.

@drdanz
Copy link
Member Author

drdanz commented Oct 12, 2020

Done, updated the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants