Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ovrheadset YARP device to a separate standalone repository. #2352

Closed
traversaro opened this issue Sep 4, 2020 · 5 comments · Fixed by #2465
Closed

Move ovrheadset YARP device to a separate standalone repository. #2352

traversaro opened this issue Sep 4, 2020 · 5 comments · Fixed by #2465
Assignees

Comments

@traversaro
Copy link
Member

To simplify installation of the software on Windows with the Oculus SDK, it would be great to move the ovrheadset YARP device to a separate repository. It could be named yarp-oculus-device or yarp-vr-devices if in the future we want to also add OpenXR-based devices.

@drdanz drdanz added Component: CMake Component: Devices Type: Task This is some task that does fall into the other "Types" labels Sep 25, 2020
@drdanz
Copy link
Member

drdanz commented Sep 25, 2020

I imported the ovrheadset here:
https://github.com/robotology/yarp-device-ovrheadset

There are probably still a couple of things to fix, but the code is officially there, and the src/devices/ovrheadset in YARP is therefore frozen.

I will remove it from YARP as soon as I am sure that it works properly.

CC @S-Dafarra @GiulioRomualdi

@drdanz
Copy link
Member

drdanz commented Dec 14, 2020

@S-Dafarra Any news on this? Did you manage to test it?

@traversaro
Copy link
Member Author

The superbuild was switched to use the new repo in robotology/robotology-superbuild#518 .

@S-Dafarra
Copy link
Contributor

@S-Dafarra Any news on this? Did you manage to test it?

I just compiled it, but I did not test it in practice. What would be the steps to move from the old YARP device to the new external one?

@traversaro
Copy link
Member Author

@S-Dafarra Any news on this? Did you manage to test it?

I just compiled it, but I did not test it in practice. What would be the steps to move from the old YARP device to the new external one?

They are drop in compatible, so I guess that if you disable the YARP one, do a clean install, and then install the new one, no further modification should be necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants