updated name of the YARP port from HDE

[davidegorbani]

After having merged robotology/human-dynamics-estimation#367 it will be necessary to merge also this PR in order to use the yarpmanager applications since the name of the YARP ports exposed by the devices in HDE are changed.

[lrapetti]

PR in human-dynamics-estimation has been merged (see https://github.com/ami-iit/ifeel_utils/blob/main/software/iFeelHDE/CMakeLists.txt#L3) and we have tested the ergocub-teleoperation application using this branch of walking-teleoperation. The PR indeed is ready to be reviewed @davidegorbani @S-Dafarra @GiulioRomualdi

[lrapetti]

@S-Dafarra @GiulioRomualdi I don't know if there is, or if it would make sense to have, a minimum required version for the dependency, such that avoid installing non-compatible configuration files. In that case we might add

find_package(HumanDynamicsEstimation 3.0.0 REQUIRED).

after realeasing human-dynamics-estimation v3.0.0 (robotology/human-dynamics-estimation#373)

[lrapetti]

cc @mebbaid

[S-Dafarra]

Thanks @davidegorbani @lrapetti. Can you please rebase on top of master. I have just merged #133 where I deleted some old files (whose modifications is thus no more required 😉 )

Also, can you avoid changing the Xprize files? I prefer to keep them "stale" for the time being.

[S-Dafarra]

@S-Dafarra @GiulioRomualdi I don't know if there is, or if it would make sense to have, a minimum required version for the dependency, such that avoid installing non-compatible configuration files. In that case we might add

find_package(HumanDynamicsEstimation 3.0.0 REQUIRED).

after realeasing human-dynamics-estimation v3.0.0 (robotology/human-dynamics-estimation#373)

Good point, the dependency is specified in

walking-teleoperation/cmake/WalkingTeleoperationFindDependencies.cmake

Lines 147 to 148 in da230ab

	find_package(HumanDynamicsEstimation QUIET)
	checkandset_dependency(HumanDynamicsEstimation)

[lrapetti]

@S-Dafarra @GiulioRomualdi I don't know if there is, or if it would make sense to have, a minimum required version for the dependency, such that avoid installing non-compatible configuration files. In that case we might add

find_package(HumanDynamicsEstimation 3.0.0 REQUIRED).

after realeasing human-dynamics-estimation v3.0.0 (robotology/human-dynamics-estimation#373)

Good point, the dependency is specified in

walking-teleoperation/cmake/WalkingTeleoperationFindDependencies.cmake

Lines 147 to 148 in da230ab

	find_package(HumanDynamicsEstimation QUIET)
	checkandset_dependency(HumanDynamicsEstimation)

I missed that, so we can:

• add the dependency on v3.0.0. (even if its not out yet)
• wait to merge it until release is done
• not add the dependency, or add it later

[lrapetti]

I missed that, so we can:

• add the dependency on v3.0.0. (even if its not out yet)
• wait to merge it until release is done
• not add the dependency, or add it later

As discussed at today meeting we will avoid adding the dependency.

[davidegorbani]

Hello @S-Dafarra, I rebased the branch and reverted the modification to the Xprise files. Should I do something else?

[S-Dafarra]

Thanks @davidegorbani! Merging

[davidegorbani]

Thank you @S-Dafarra !