Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add frameName and frame parameters in FT sensor #45

Merged
merged 2 commits into from
Nov 24, 2020
Merged

Add frameName and frame parameters in FT sensor #45

merged 2 commits into from
Nov 24, 2020

Conversation

Nicogene
Copy link
Member

@Nicogene Nicogene commented Nov 19, 2020 •
edited
Loading

To be filled.

It fixes #44

@Nicogene Nicogene self-assigned this Nov 19, 2020
@Nicogene Nicogene mentioned this pull request Nov 20, 2020
Merged
@Nicogene Nicogene force-pushed the feat/addFrameFTSensor branch from a4c6f52 to 3919568 Compare November 20, 2020 16:56
@Nicogene Nicogene changed the title WIP: first draft for adding frameName in FT sensor Add frameName and frame parameters in FT sensor Nov 23, 2020
@Nicogene Nicogene marked this pull request as ready for review November 23, 2020 14:48
@Nicogene
Copy link
Member Author

@traversaro it should be ready now for review

@traversaro
Copy link
Member

If it is not too difficult, can we early fail if the frame has a value different from sensor , child or parent instead of generating a malformed model?

@Nicogene Nicogene force-pushed the feat/addFrameFTSensor branch from 10fc83b to eeda937 Compare November 23, 2020 15:05
@Nicogene Nicogene requested a review from traversaro November 23, 2020 15:06
@Nicogene Nicogene force-pushed the feat/addFrameFTSensor branch from eeda937 to 64d7358 Compare November 24, 2020 09:43
@Nicogene Nicogene requested a review from traversaro November 24, 2020 09:43
@traversaro
Copy link
Member

Great!

@Nicogene Nicogene merged commit f6055ab into master Nov 24, 2020
@Nicogene Nicogene deleted the feat/addFrameFTSensor branch November 24, 2020 09:53
@Nicogene Nicogene mentioned this pull request Jun 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@traversaro traversaro traversaro approved these changes

Assignees

@Nicogene Nicogene

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add frame and frameName options to forceTorqueSensors
2 participants
@Nicogene @traversaro