Fix malformed link material element #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The URDF specification allows to have a material element without a color child element, but only if the name of the color is specified in the model-wide material database. Otherwise, it is always necessary to specify the color of the material of the link. Fix robotology/icub-models-generator#36 See robotology/icub-models-generator#36 (comment)
traversaro
changed the title
|
Friendly ping @diegoferigo @fiorisi |
diegoferigo
approved these changes
Jun 20, 2018
|
@diegoferigo @fiorisi Can we manually ask for a new generation of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The URDF "specification" ( http://wiki.ros.org/urdf ) and its "reference implementation" ( https://github.com/ros/urdfdom ) allow to have a material element without a color child element,
but only if the name of the color is specified in the model-wide material database.
Otherwise, it is always necessary to specify the color of the material of the link.
Fix robotology/icub-models-generator#36
See robotology/icub-models-generator#36 (comment)
This should get rid of the terrible
[ERROR] :: parseURDFMaterial : Impossible to parse URDF material, material black not found in model database.warnings when loading an iCub model generated withsimmechanics-to-urdf.