Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to robotology #2

Closed
traversaro opened this issue Mar 29, 2018 · 13 comments
Closed

Migrate to robotology #2

traversaro opened this issue Mar 29, 2018 · 13 comments
Assignees

Comments

@traversaro
Copy link
Member

Ad discussed with @GiulioRomualdi and @S-Dafarra, it would be useful to move this repo to robotology .
For this, we should rename the repo to have a name compliant to robotology organization style.
@GiulioRomualdi let me know when you are ready to move (note that GitHub handles renaming quite well, so this should not be problematic in any way).

cc @DanielePucci

@GiulioRomualdi
Copy link
Member

Ok, as regarding the name of the repo what do you prefer?

  1. osqp-c++;
  2. osqp-eigen;
  3. osqp-c++-eigen;
  4. ...

@traversaro
Copy link
Member Author

I think osqp-eigen is the most descriptive one, if you want to have c++ in the name I would go for cxx or cpp to avoid strange corner-case problems with having + in the package/repo name.

@traversaro
Copy link
Member Author

traversaro commented Mar 31, 2018

The osqp-something naming scheme is also compatible with the names of the repositories of osqp bindings for Python, Fortran and MATLAB: https://github.com/oxfordcontrol .

If you want visibility for the library, once you are a bit confident that the API interface is stable (ish), you could propose to OSQP's authors to include the link to this Eigen interface to OSQP in the OSQP Interfaces page: http://osqp.readthedocs.io/en/latest/interfaces/ (there are already some 3rd-party interfaces such as cutest).

@GiulioRomualdi
Copy link
Member

GiulioRomualdi commented Apr 3, 2018

Ok the name of the repository will be changed into osqp-eigen. The master branch is fully tested while, in the next few days, I will write some tests for the devel_update_matrices branch.

@S-Dafarra
Copy link
Collaborator

Maybe when migrating we could change Optimizator* to Optimizer* 😉 .

@GiulioRomualdi
Copy link
Member

Maybe when migrating we could change Optimizator* to Optimizer* 😉 .

Done! 😄

@GiulioRomualdi
Copy link
Member

Porting can be performed when this issue will be closed.

@GiulioRomualdi GiulioRomualdi self-assigned this May 15, 2018
@ahoarau
Copy link
Member

ahoarau commented Jun 3, 2018

@traversaro You are everywhere I look ! 😃

Question : Isn't the default licensing for robotology LGPLv2-3 ? I'd like to use this but not put my code GPL

@traversaro
Copy link
Member Author

Hi @ahoarau !
Yep the software is licensed under LGPL2/3, the content of the LICENSE file will be changed soon, thanks for pointing that out.

@S-Dafarra
Copy link
Collaborator

S-Dafarra commented Jun 8, 2018

Just a couple of suggestions before migrating to robotology.
Maybe it is better to rename the files from Optimizer* to OsqpEigen*, to make clearer the inclusion of these files in external projects. In addition the name OptimizerSolver seems a repetition.
Another option could be to remove Optimizer* from the file name and place them all in a folder called OsqpEigen, so that the inclusion would seem like:

#include <OsqpEigen/Solver.hpp>

instead of

#include <OptimizerSolver.hpp>

I would suggest also to change the name of the namespace from OsqpWrapper to OsqpEigen to preserve consistency with the project name.

I can deal with these modification if you like, maybe adding them to https://github.com/GiulioRomualdi/osqp-eigen/pull/5.

Clearly this would break the code which has been written according to the current version, but it may be reasonable to change it when migrating organization.

@GiulioRomualdi
Copy link
Member

GiulioRomualdi commented Jun 11, 2018

Since #5 and #7 were merged and the license was updated (now LGPL 3) we can move this repository to robotology.
@DanielePucci @S-Dafarra @traversaro

@GiulioRomualdi
Copy link
Member

I think we can close this issue.

@traversaro
Copy link
Member Author

Yeah!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants