Do not call find_package(pybind11 QUIET) if IDYNTREE_USES_PYTHON_PYBIND11 is OFF #877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ND11 is OFF Calling find_package(pybind11) can create configuration failures even if the QUIET option is passed (see #876). As at the moment there is not automatic detection of pybind11 to enable the pybind11 bindings, it is just easier to properly search for pybind11 if IDYNTREE_USES_PYTHON_PYBIND11 is ON, and do not do anything otherwise. Fix related to #876 .
traversaro
requested review from
francesco-romano,
GiulioRomualdi and
diegoferigo
diegoferigo
approved these changes
Jun 11, 2021
francesco-romano
approved these changes
Jun 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling find_package(pybind11) can create configuration failures even if the QUIET option is passed (see #876).
As at the moment there is not automatic detection of pybind11 to enable the pybind11 bindings, it is just easier to properly search for pybind11 if IDYNTREE_USES_PYTHON_PYBIND11 is ON, and do not do anything otherwise.
Fix related to #876 .