Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compilation of Python bindings on Windows #843

Merged
merged 2 commits into from
Apr 8, 2021
Merged

Fix compilation of Python bindings on Windows #843

merged 2 commits into from
Apr 8, 2021

Conversation

traversaro
Copy link
Member

@traversaro traversaro commented Apr 2, 2021 •
edited
Loading

@traversaro traversaro mentioned this pull request Apr 2, 2021
Merged
nunoguedelha
nunoguedelha reviewed Apr 6, 2021
View reviewed changes
Copy link
Contributor

@nunoguedelha nunoguedelha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @traversaro , I don't understand the relation between this implementation and the one in robotology/yarp#2527. Note that I don't know much about Python bindings...

@traversaro
Copy link
Member Author

Sorry @traversaro , I don't understand the relation between this implementation and the one in robotology/yarp#2527. Note that I don't know much about Python bindings...

They are not related, the bugs are different. In this case, the problem is that options that are supported just in GCC/Clang are passed to MSVC, resulting in a compilation failure, so the PR ensure that if MSVC is used, these options are not passed.

@nunoguedelha
Copy link
Contributor

They are not related, the bugs are different. In this case, the problem is that options that are supported just in GCC/Clang are passed to MSVC, resulting in a compilation failure, so the PR ensure that if MSVC is used, these options are not passed.

Ah ok. I had misunderstood your initial description of this issue. Got it.

@traversaro traversaro merged commit f3ba2e1 into master Apr 8, 2021
@traversaro traversaro deleted the fix-python-windows branch April 8, 2021 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunoguedelha nunoguedelha nunoguedelha left review comments

@Nicogene Nicogene Nicogene approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@traversaro @nunoguedelha @Nicogene