Fix compilation of IDYNTREE_USES_MATLAB when SWIG is not found #790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
traversaro
requested review from
lrapetti,
AlbertoRemus and
AngeloRendiniello
This is particularly convenient on Windows, where install SWIG (when not using conda-forge) is not obvious. As additional cleanup, modify find_package(MATLAB) calls to only ask for the required components, and use matlab_add_mex to ensure that visibility is properly addressed for on Windows.
traversaro
force-pushed
the
cleanupMATLABswig
branch
from
b6dd95e to
b020814
Compare
AlbertoRemus
approved these changes
Dec 4, 2020
This was referenced Jan 13, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is particularly convenient on Windows, where install SWIG (when not using conda-forge) is not obvious. In particular,
${SWIG_USE_FILE}is defined only when SWIG is found, so the current version fails as${SWIG_USE_FILE}is empty.As additional cleanup, modify find_package(MATLAB) calls to only ask for the required components, i.e.
MEX_LIBRARYnormally andMAIN_PROGRAMonly when tests are enabled.Furthermore, while testing I noticed that the MATLAB bindings were not working on Windows for the "Gateway function not found error", I fixed it by switching to use
matlab_add_mex. This in particular could impact @AngeloRendiniello @singhbal-baljinder @AlbertoRemusIIT , so once this is merged I will release 2.0.2 .