Feature/properly handle link solid shapes #658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
traversaro
reviewed
Mar 26, 2020
|
The change seems fine, can you update the CHANGELOG ( https://github.com/robotology/idyntree/blob/devel/CHANGELOG.md )? Thanks! |
Yes, deleting the commented test. Co-Authored-By: Silvio Traversaro <silvio.traversaro@iit.it>
|
@traversaro can I merge? |
traversaro
approved these changes
Apr 1, 2020
|
Hi @fjandrad , on iDynTree I tipically handle merge personally being the maintainer. For the future, please reply to the PR when you address a review comment, otherwise the reviewer does not get any notification if you just push to the branch without any comment. |
Will do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added templates to correctly handle the modelSolidShapes type of variable obtained with the method
model.visualSolidShapes.linkSolidShapes
The reference issue is #656