Add matlab/octave high level wrappers #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @traversaro |
|
Ignore the Travis failure, is actually due to #531 . |
traversaro
requested changes
Apr 16, 2019
|
Think I addressed all the comments with this commit: bdb902a |
|
Thanks. Can you add a line on this PR in the release notes: https://github.com/robotology/idyntree/blob/devel/doc/releases/v0_12.md ? |
|
I've updated the file in my branch as I don't have write access on the main |
traversaro
reviewed
Apr 16, 2019
doc/releases/v0_12.md
Outdated
| @@ -42,6 +42,9 @@ KinDynComputations finally reached feature parity with respect to DynamicsComput | |||
| * Added `bindings` for `AttitudeMahonyFilter`, `AttitudeQuaternionEKF`, `DiscreteExtendedKalmanFilterHelper` (https://github.com/robotology/idyntree/pull/522) | |||
| * Added basic tests for the Attitude Estimator classes (https://github.com/robotology/idyntree/pull/522) | |||
|
|
|||
| #### `bindings` | |||
| * Added high-level Matlab/Octave wrappers of the iDyntree bindings. Related PR: (https://github.com/robotology/idyntree/pull/530) | |||
There was a problem hiding this comment.
Suggested change
| * Added high-level Matlab/Octave wrappers of the iDyntree bindings. Related PR: (https://github.com/robotology/idyntree/pull/530) | |
| * Added high-level Matlab/Octave wrappers of the iDyntree bindings (https://github.com/robotology/idyntree/pull/530) |
Let's try to keep consistency internally to the same document
|
@gabrielenava You want to clean the commits or I "Squash and merge" when merging the PR? |
|
Cleaned! |
|
Sorry @gabrielenava , I meant Do you want to clean the commits or I "Squash and merge" when merging the PR? |
|
I think squash and merge when merging the PR is ok |
traversaro
approved these changes
Apr 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wrote a collection of
high-level wrappersfor simplifying the usage of iDyntree inside Matlab. This PR is for moving the wrappers inside iDyntree. I also designed a smoke-test to verify if the wrappers are correctly called.