Merge ***Raw classes in the non-Raw equivalents, and deprecate Raw classes #1114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
traversaro
force-pushed
the
cleanupraw
branch
from
f400418 to
140fdd1
Compare
|
There are a few CI failure, due to MATLAB tests failing. My plan is to merge #1112 and then rebase this PR on top of that, and generating bindings, so we re-generated MATLAB bindings just once. |
traversaro
force-pushed
the
cleanupraw
branch
from
4bc7ce9 to
3e4f851
Compare
traversaro
force-pushed
the
cleanupraw
branch
from
3e4f851 to
f4e2f20
Compare
Co-authored-by: traversaro <traversaro@users.noreply.github.com>
|
|
|
The only failures are not related to the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some "logical" classes in iDynTree were split across two different classes, i.e.
RotationandRotationRaw,PositionandPositionRaw, ... . This difference was there just for historical reason (related to semantic checks, that were removed in #704), so by merging Raw classes with their non-Raw counterpart permit to simplify the codebase.