Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix support for PrismaticJoint in iDynTree::getRandomModel #1057

Merged
merged 3 commits into from
Mar 28, 2023

Conversation

traversaro
Copy link
Member

@traversaro traversaro commented Mar 22, 2023

The actual method was fixed accidentally with a direct push to master (see 9c7f2b3), anyhow more fixes were necessary (for example, when passing noFixed argument no prismatic joint were generated), so this PR adds the necessary bits.

@traversaro
Copy link
Member Author

Apparently InverseKinematics tests do not work with prismatic joints:

	 92 - UnitTestInverseKinematics (Failed)
	 93 - memcheck_UnitTestInverseKinematics (Failed)
	 94 - UnitTestInverseKinematicsMatrixViewAndSpan (Failed)
	 95 - memcheck_UnitTestInverseKinematicsMatrixViewAndSpan (Failed)

@traversaro
Copy link
Member Author

Probably we just convert the old noFixedJoint to onlyRevolute, this should simplify the implementation and cover the old behaviour.

@traversaro traversaro requested a review from S-Dafarra March 28, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants