Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the IDYNTREE_USES_IRRLICHT option in pip/PyPI builds #1045

Merged
merged 8 commits into from
Jan 16, 2023

Conversation

traversaro
Copy link
Member

This should solve errors like:

Traceback (most recent call last):
  File "src/eCub_lenghtAndDensityWithHumanOptimization.py", line 174, in <module>
    VisualizationHelper.prepare_visualization()
  File "/src/OutputVisualization.py", line 27, in prepare_visualization
    self.viz.camera().animator().enableMouseControl(True)
AttributeError: 'NoneType' object has no attribute 'enableMouseControl'
The command '/bin/bash -c python3 src/eCub_lenghtAndDensityWithHumanOptimization.py' returned a non-zero code: 1

when the PyPI build of iDynTree is used.

@traversaro
Copy link
Member Author

@diegoferigo do you see anything problematic in this?

@diegoferigo diegoferigo self-requested a review January 16, 2023 14:01
Copy link
Member

@diegoferigo diegoferigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@diegoferigo do you see anything problematic in this?

At first look no, it seems you've already done all the right steps to install irrlicht in the image used to build the wheels and configured correctly the CMake called by setuptools.

@traversaro
Copy link
Member Author

@diegoferigo do you see anything problematic in this?

At first look no, it seems you've already done all the right steps to install irrlicht in the image used to build the wheels and configured correctly the CMake called by setuptools.

Great! I am quite afraid on possible runtime problems introduced by the additional transitive dependencies of irrlicht (zlib, libpng, etc etc), but anyhow this is the price you have to pay when you package with pip/PyPI C++ libraries with many dependency, and we will only discover if this is it is a problem by trying.

@traversaro traversaro merged commit 51d5c74 into master Jan 16, 2023
@traversaro traversaro deleted the enableirrlichtinpypibuilds branch January 16, 2023 14:07
@diegoferigo
Copy link
Member

@diegoferigo do you see anything problematic in this?

At first look no, it seems you've already done all the right steps to install irrlicht in the image used to build the wheels and configured correctly the CMake called by setuptools.

Great! I am quite afraid on possible runtime problems introduced by the additional transitive dependencies of irrlicht (zlib, libpng, etc etc), but anyhow this is the price you have to pay when you package with pip/PyPI C++ libraries with many dependency, and we will only discover if this is it is a problem by trying.

Yep let's wait and see. In CI, auditwheel should perform automatically the vendoring of dependent shared libraries, no further edit is necessary. Then, for the interaction with other packages, only time will tell :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants