-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable the IDYNTREE_USES_IRRLICHT option in pip/PyPI builds #1045
Conversation
@diegoferigo do you see anything problematic in this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@diegoferigo do you see anything problematic in this?
At first look no, it seems you've already done all the right steps to install irrlicht in the image used to build the wheels and configured correctly the CMake called by setuptools.
Great! I am quite afraid on possible runtime problems introduced by the additional transitive dependencies of irrlicht (zlib, libpng, etc etc), but anyhow this is the price you have to pay when you package with pip/PyPI C++ libraries with many dependency, and we will only discover if this is it is a problem by trying. |
Yep let's wait and see. In CI, auditwheel should perform automatically the vendoring of dependent shared libraries, no further edit is necessary. Then, for the interaction with other packages, only time will tell :) |
This should solve errors like:
when the PyPI build of iDynTree is used.