-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid to compute the pseudoinverse to evaluate the external wrenches #1017
Conversation
I just realized that in most cases we can also avoid the Qr decomposition, as in the submodels has only one full wrench as unknown, in the equation Ax = b the A is just an adjoint matrix for which the inverse is trivial. However, computing this "special case" is probably more complex that this change, so let's see how time the use of Qr saves. |
I would like to present you some results. I used The following figures shows the result in case of
Accordingly to the results the approach I proposed is 2 times faster than the original one. |
Great, let's merge then. Given that the base branch of the PR for some reason is quite old, can I rebase on top of the latest master to run the CI? |
sure! |
1755551
to
a3d8fdc
Compare
CI is failing as we modified a structures without re-generating MATLAB bindings, I just launched the action to regenerated the bindings: https://github.com/robotology/idyntree/actions/runs/2949426070 . |
update matlab bindings
@gabrielenava we might consider to re-install the iDyntree for the iRonCub |
According to https://eigen.tuxfamily.org/dox/group__LeastSquares.html this should be more efficient
cc @traversaro @S-Dafarra