Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add force arrows to the HumanStateVisualizer #241

Merged
merged 2 commits into from
Mar 5, 2021
Merged

Conversation

lrapetti
Copy link
Member

@lrapetti lrapetti commented Mar 3, 2021

This PR close #240 by adding the possibility to visualize the force associated to a given link by reading its value from the HumanWrenchProvider trough an analogServer.

The PR is ready, as shown in #240 (comment), but waiting for a fix in iDynTree to be merged (robotology/idyntree#838)

@lrapetti lrapetti added this to the AnDy - Iteration 57 milestone Mar 3, 2021
@lrapetti lrapetti self-assigned this Mar 3, 2021
@lrapetti
Copy link
Member Author

lrapetti commented Mar 3, 2021

The PR is ready, as shown in #240 (comment), but waiting for a fix in iDynTree to be merged (robotology/idyntree#838)

The PR on iDynTree was merged, so we can proceed with merging also this PR.

Note that currently, the new feature will work properly only on master, but still it compiles and runs with previous tags (e.g. the CI tag 3.0.0) but the force vectors will be positioned in the origin because of the bug described in robotology/idyntree#835

Copy link
Contributor

@S-Dafarra S-Dafarra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I would just argue that reading two wrenches simply as 12 numbers without any other indication is a bit risky in terms of portability. You need to make sure that the configuration file is always aligned with what provides you those forces, but I think this is not the aim of this PR in any case.

@lrapetti
Copy link
Member Author

lrapetti commented Mar 3, 2021

Looks good to me. I would just argue that reading two wrenches simply as 12 numbers without any other indication is a bit risky in terms of portability.

I completely agree. Unfortunately that is how the force values are currently streamed by the HumanWrenchProvider, in order to have a better solution we should first improve the way those data are exposed by that device.

@lrapetti
Copy link
Member Author

lrapetti commented Mar 3, 2021

Looks good to me. I would just argue that reading two wrenches simply as 12 numbers without any other indication is a bit risky in terms of portability.

I completely agree. Unfortunately that is how the force values are currently streamed by the HumanWrenchProvider, in order to have a better solution we should first improve the way those data are exposed by that device.

I also considered reading direcly the wrench values for the shoes (e.g. using IWear interface), but in that case we would need to pass the visualizer some parameters (shoes frame position and orientation), which would have anyway created confusion in configuration files.

@lrapetti lrapetti merged commit 86dfc53 into master Mar 5, 2021
@yeshasvitirupachuri yeshasvitirupachuri deleted the feature/add-arrow-viz branch March 29, 2021 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add forces visualization in HumanStateVisualizer
2 participants